Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with "grpc: received message larger than max ..." #3004

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

chensun
Copy link
Member

@chensun chensun commented Feb 6, 2020

  • The default ServerOption MaxRecvMsgSize is 4MB, and we might hit this limit when loading a large number of runs. Increase the limit to 2GB (MaxInt32).

  • Minor fix: golang import ordering/grouping

@jingzhang36 @IronPan


This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Feb 6, 2020

@IronPan We probably should not sent all workflow bodies to the UX when listing runs.
What do you think about adding some more UX-oriented API methods?

@numerology numerology changed the title Fix issue with "grpc: rececived message larger than max ..." Fix issue with "grpc: received message larger than max ..." Feb 6, 2020
@Ark-kun
Copy link
Contributor

Ark-kun commented Feb 6, 2020

/retest

@jessiezcc
Copy link
Contributor

/lgtm

@chensun
Copy link
Member Author

chensun commented Feb 6, 2020

/retest

@IronPan
Copy link
Member

IronPan commented Feb 6, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun
Copy link
Member Author

chensun commented Feb 6, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit d26a216 into kubeflow:master Feb 7, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Enable triton e2e test

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Add triton with transformer e2e test and fix custom transformer

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants